ADFA-3681 | Fix Llama C++ build warnings - #57
Open
jatezzz wants to merge 2 commits into
Open
Conversation
The script copied to a nonexistent ai-core-plugin/libs/ instead of the libs/ paths build.gradle.kts declares. Also check build outputs exist before copying, so a failed build cannot leave stale artifacts.
std::wstring_convert is deprecated in C++17, removed in C++26. Decode UTF-8 to UTF-16 explicitly and keep env->NewString; NewStringUTF expects CESU-8 and would mangle emoji. Invalid input now degrades per-sequence.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
jatezzz
requested review from
a team,
Daniel-ADFA,
dara-abijo-adfa,
hal-eisen-adfa and
itsaky-adfa
July 31, 2026 15:39
hal-eisen-adfa
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced the deprecated
std::codecvt_utf8_utf16andstd::wstring_convertin the JNI string conversion with a custom UTF-8 to UTF-16 parser to eliminate build warnings during the:llama-implbuild process. Additionally, corrected the artifact paths in therebuild-llama-aar.shscript to ensure proper generation.Details
The build logs will no longer display the
-Wdeprecated-declarationswarnings when compiling thellama-android.cppnative library.Ticket
ADFA-3681
Observation
The custom UTF-8 to UTF-16 parser safely handles valid multi-byte sequences (including 4-byte emoji characters) and substitutes invalid bytes with
?, guaranteeing that a truncated or invalid sequence cannot corrupt the remainder of the string.